From f2fb296698bd48db109f5842ba66ce510c79d68e Mon Sep 17 00:00:00 2001
From: RatzzFatzz <michael@ratzloeffel.de>
Date: Thu, 17 Mar 2022 18:58:05 +0100
Subject: [PATCH] Make use of String.format

---
 .../config/ConfigProcessor.java               | 23 +++++++++++--------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/main/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/config/ConfigProcessor.java b/src/main/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/config/ConfigProcessor.java
index 137adf2..82d2972 100644
--- a/src/main/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/config/ConfigProcessor.java
+++ b/src/main/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/config/ConfigProcessor.java
@@ -12,6 +12,8 @@ import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
 
+import static java.lang.String.format;
+
 @Log4j2
 public class ConfigProcessor {
     private int audioDefault = - 1;
@@ -83,31 +85,32 @@ public class ConfigProcessor {
      *
      * @param file       is the file, which will be updated
      * @param attributes has the metadata for the transferred file
-     * @return if the the current file was updated or not. Returns true if the file already has the correct metadata set
+     * @return if the current file was updated or not. Returns true if the file already has the correct metadata set
      */
     private boolean updateFile(File file, List<FileAttribute> attributes, TransferObject transfer) {
         StringBuilder stringBuffer = new StringBuilder();
         if(System.getProperty("os.name").toLowerCase().contains("windows")){
-            stringBuffer.append("\"");
-            stringBuffer.append(MKVToolProperties.getInstance().getMkvpropeditPath());
-            stringBuffer.append("\" \"").append(file.getAbsolutePath()).append("\" ");
+            stringBuffer.append(format("\"%s\" \"%s\" ",
+                    MKVToolProperties.getInstance().getMkvpropeditPath(),
+                    file.getAbsolutePath()));
         }else{
-            stringBuffer.append(MKVToolProperties.getInstance().getMkvpropeditPath());
-            stringBuffer.append(" ").append(file.getAbsolutePath()).append(" ");
+            stringBuffer.append(format("%s %s ",
+                    MKVToolProperties.getInstance().getMkvpropeditPath(),
+                    file.getAbsolutePath()));
         }
         if(audioDefault != - 1){
-            stringBuffer.append("--edit track:=").append(audioDefault).append(" --set flag-default=0 ");
+            stringBuffer.append(format("--edit track:=%s --set flag-default=0 ", audioDefault));
         }
         if(subtitleDefault != - 1){
-            stringBuffer.append("--edit track:=").append(subtitleDefault).append(" --set flag-default=0 ");
+            stringBuffer.append(format("--edit track:=%s --set flag-default=0 ", subtitleDefault));
         }
         collectLines(attributes, transfer);
         if(transfer.isValid){
             if(transfer.isAudioOn){
-                stringBuffer.append("--edit track:=").append(transfer.getAudioIndex()).append(" --set flag-default=1 ");
+                stringBuffer.append(format("--edit track:=%s --set flag-default=1 ", transfer.getAudioIndex()));
             }
             if(transfer.isSubtitleOn){
-                stringBuffer.append("--edit track:=").append(transfer.getSubtitleIndex()).append(" --set flag-default=1 ");
+                stringBuffer.append(format("--edit track:=%s --set flag-default=1 ", transfer.getSubtitleIndex()));
             }
             if(subtitleDefault == transfer.getSubtitleIndex() && audioDefault == transfer.getAudioIndex()){
                 /*