Handle empty input

README.md

@@ -1,49 +1,62 @@
 ## Introduction
 
-This program helps to change audio and subtitle tracks of mkv files without rewriting the file. Only track properties will be updated.
+A streamlined solution for managing MKV files, this program leverages MKVToolNix to modify audio and subtitle track properties without the need for time-consuming file reencoding. Users can easily set their track preferences, and the application intelligently applies the best matching configuration. The tool focuses on metadata modification rather than full file rewriting, ensuring quick operations while maintaining the original file integrity. This makes it an ideal choice for managing multilingual media collections or batch processing multiple MKV files.
+
 ![](https://github.com/RatzzFatzz/MKVAudioSubtitleChanger/blob/master/example.gif)
 
 ## Requirements
 
- - Java 11 or higher
+ - Java 21 or newer
  - mkvtoolnix installation
  
 ## Execution
-**Minimal usage:**
-`java -jar mkvaudiosubtitlechanger.jar --library "X:/Files" --attribute-config eng:ger eng:OFF`
+### Minimal usage
+Portable: `java -jar mkvaudiosubtitlechanger-<version>.jar --library "X:/Files" --attribute-config eng:ger eng:OFF`
 
-**Safe usage (best for testing before applying to whole library):**
-`java -jar mkvaudiosubtitlechanger.jar --library "X:/Files" --attribute-config eng:ger eng:OFF --safe-mode`
+Windows (installed): `mkvaudiosubtitlechanger.jar --library "X:/Files" --attribute-config eng:ger eng:OFF`
 
-Attribute-config must be entered in pairs: `audio:subtitle`; Example: `jpn:eng`. More about this topic
-[here](https://github.com/RatzzFatzz/MKVAudioSubtitleChanger/wiki/Attribute-Config).
+### Safe usage (best for testing before applying to whole library)
+Portable: `java -jar mkvaudiosubtitlechanger-<version>.jar --library "X:/Files" --attribute-config eng:ger eng:OFF --safe-mode`
+
+Windows (installed): `mkvaudiosubtitlechanger.jar --library "X:/Files" --attribute-config eng:ger eng:OFF --safe-mode`
+
+**Attribute-config must be entered in pairs: `audio:subtitle`; Example: `jpn:eng`. More about this topic
+[here](https://github.com/RatzzFatzz/MKVAudioSubtitleChanger/wiki/Attribute-Config).**
 
 ## Available parameters
 ```
- -l,--library-path <arg>           Path to library
- -a,--attribute-config <arg>       Attribute config to decide which tracks to choose when
- -p,--config-path <arg>            Path to config file
- -m,--mkvtoolnix <arg>             Path to mkv tool nix installation
- -s,--safe-mode                    Test run (no files will be changes)
- -c,--coherent <arg>               Try to match all files in dir of depth with the same config
- -cf,--force-coherent              Force coherent and don't update anything if config fits not whole config (default: false)
- -n,--only-new-files               Sets filter-date to last successful execution (Overwrites input of filter-date)
- -d,--filter-date <arg>            Only consider files created newer than entered date (format: "dd.MM.yyyy-HH:mm:ss")
- -t,--threads <arg>                Thread count (default: 2)
- -i,--include-pattern <arg>        Include files matching pattern (default: ".*")
- -e,--excluded-directories <arg>   Directories to be excluded, combines with config file
- -fk,--forced-keywords <arg>       Additional keywords to identify forced tracks
- -ck,--commentary-keywords <arg>   Additional keywords to identify commentary tracks
- -ps,--preferred-subtitles <arg>   Additional keywords to prefer specific subtitle tracks
- -v,--version                      Display version
- -h,--help                         "For help this is" - Yoda
+  -a, --attribute-config=<attributeConfig>...
+                            List of audio:subtitle pairs used to match in order and update files accordingly (e.g. jpn:eng jpn:ger)
+  -c, --coherent=<coherent> try to match all files in dir of depth with the same attribute config
+      -cf, --force-coherent changes are only applied if it's a coherent match
+      --commentary-keywords=<commentaryKeywords>[, <commentaryKeywords>...]...
+                            Keywords to identify commentary tracks (Defaults will be overwritten; Default: commentary, director)
+  -d, --filter-date=<filterDate>
+                            only consider files created newer than entered date (format: "dd.MM.yyyy-HH:mm:ss")
+  -e, --excluded-directory=<excludedDirectories>...
+                            Directories to be excluded, combines with config file
+      --forced-keywords=<forcedKeywords>[, <forcedKeywords>...]...
+                            Keywords to identify forced tracks (Defaults will be overwritten; Default: forced, signs, songs)
+  -h, --help                Show this help message and exit.
+  -i, --include-pattern=<includePattern>
+                            include files matching pattern (default: ".*")
+  -l, --library=<libraryPath>
+                            path to library
+  -m, --mkvtoolnix=<mkvToolNix>
+                            path to mkvtoolnix installation
+  -n, --only-new-file       sets filter-date to last successful execution (overwrites input of filter-date)
+      --preferred-subtitles=<preferredSubtitles>[, <preferredSubtitles>...]...
+                            Keywords to prefer specific subtitle tracks (Defaults will be overwritten; Default: unstyled)
+  -s, --safemode            test run (no files will be changes)
+  -t, --threads=<threads>   thread count (default: 2)
+  -V, --version             Print version information and exit.
 ```
-If you need more information about how each parameter works, check out [this wiki page](https://github.com/RatzzFatzz/MKVAudioSubtitleChanger/wiki/Parameters).
+If you need more information how each parameter works, check out [this wiki page](https://github.com/RatzzFatzz/MKVAudioSubtitleChanger/wiki/Parameters-v4).
 
-All parameters can also be defined in a [config file](https://github.com/RatzzFatzz/MKVAudioSubtitleChanger/wiki/How-to-config-file).
+All parameters can also be defined in a [config file](https://picocli.info/#_argument_files_for_long_command_lines).
 
 ## Build requirements
-- JDK 11 or higher
+- JDK 21 or newer
 - Maven 3
 - Git
 
@@ -51,5 +64,5 @@ All parameters can also be defined in a [config file](https://github.com/RatzzFa
 ```shell
 git clone https://github.com/RatzzFatzz/MKVAudioSubtitleChanger.git
 cd MKVAudioSubtitleChanger
-mvn package
+mvn clean package -Pportable
 ```

src/main/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/Main.java

@@ -18,11 +18,12 @@ import java.util.Set;
 
 @Slf4j
 @CommandLine.Command(
-        name = "mkvasc",
+        name = "mkvaudiosubtitlechanger",
         usageHelpWidth = 120,
         customSynopsis = {
-                "mkvasc -a <attributeConfig>... -l <libraryPath> [-s]",
-                "Example: mkvasc -a eng:eng eng:ger -l /mnt/media/ -s"
+                "mkvaudiosubtitlechanger -a <attributeConfig>... -l <libraryPath> [-s]",
+                "Example: mkvaudiosubtitlechanger -a eng:eng eng:ger -l /mnt/media/ -s",
+                ""
         },
         mixinStandardHelpOptions = true,
         versionProvider = ProjectUtil.class
@@ -60,6 +61,9 @@ public class Main implements Runnable {
     }
 
     public static void main(String[] args) {
+        if (args.length == 0) {
+            args = new String[] { "--help" };
+        }
         new CommandLine(Main.class).execute(args);
     }
 }

src/main/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/config/Config.java

@@ -30,7 +30,8 @@ public class Config {
     @CommandLine.Spec
     CommandLine.Model.CommandSpec spec;
 
-    @CommandLine.Option(names = {"-a", "--attribute-config"}, required = true, arity = "1..*", converter = AttributeConfigConverter.class)
+    @CommandLine.Option(names = {"-a", "--attribute-config"}, required = true, arity = "1..*", converter = AttributeConfigConverter.class,
+            description = "List of audio:subtitle pairs used to match in order and update files accordingly (e.g. jpn:eng jpn:ger)")
     private List<AttributeConfig> attributeConfig;
 
     @Setter(AccessLevel.NONE)
@@ -51,7 +52,7 @@ public class Config {
     @CommandLine.Option(names = {"-cf", "--force-coherent"}, description = "changes are only applied if it's a coherent match")
     private boolean forceCoherent;
 
-    @CommandLine.Option(names = {"-n"}, description = "sets filter-date to last successful execution (overwrites input of filter-date)")
+    @CommandLine.Option(names = {"-n", "--only-new-file"}, description = "sets filter-date to last successful execution (overwrites input of filter-date)")
     private boolean onlyNewFiles;
     @CommandLine.Option(names = {"-d", "--filter-date"}, defaultValue = CommandLine.Option.NULL_VALUE, description = "only consider files created newer than entered date (format: \"dd.MM.yyyy-HH:mm:ss\")")
     private Date filterDate;
@@ -61,15 +62,15 @@ public class Config {
             description = "Directories to be excluded, combines with config file")
     private Set<String> excludedDirectories = new HashSet<>();
 
-    @CommandLine.Option(names = {"-fk", "--force-keywords"}, arity = "1..*",
-            description = "Additional keywords to identify forced tracks (Defaults are will be overwritten; Default: ${DEFAULT-VALUE}")
-    private Set<String> forcedKeywords = new HashSet<>(Arrays.asList("forced", "signs", "songs"));
-    @CommandLine.Option(names = {"-ck", "--commentary-keywords"}, arity = "1..*",
-            description = "Additional keywords to identify commentary tracks (Defaults are will be overwritten; Default: ${DEFAULT-VALUE}")
-    private Set<String> commentaryKeywords = new HashSet<>(Arrays.asList("commentary", "director"));
-    @CommandLine.Option(names = {"-ps", "--preferred-subtiltes"}, arity = "1..*",
-            description = "Additional keywords to prefer specific subtitle tracks (Defaults are will be overwritten; Default: ${DEFAULT-VALUE}")
-    private Set<String> preferredSubtitles = new HashSet<>(Arrays.asList("unstyled"));
+    @CommandLine.Option(names = {"--forced-keywords"}, arity = "1..*", defaultValue = "forced, signs, songs", split = ", ",
+            description = "Keywords to identify forced tracks (Defaults will be overwritten; Default: ${DEFAULT-VALUE})")
+    private Set<String> forcedKeywords;
+    @CommandLine.Option(names = {"--commentary-keywords"}, arity = "1..*", defaultValue = "commentary, director", split = ", ",
+            description = "Keywords to identify commentary tracks (Defaults will be overwritten; Default: ${DEFAULT-VALUE})")
+    private Set<String> commentaryKeywords;
+    @CommandLine.Option(names = {"--preferred-subtitles"}, arity = "1..*", defaultValue = "unstyled", split = ", ",
+            description = "Keywords to prefer specific subtitle tracks (Defaults will be overwritten; Default: ${DEFAULT-VALUE})")
+    private Set<String> preferredSubtitles;
 
     @CommandLine.Option(names = {"-l", "--library"}, required = true, description = "path to library")
     public void setLibraryPath(File libraryPath) {

src/main/resources/log4j2-dev.yaml

@@ -10,7 +10,7 @@ Configuration:
     RollingFile:
       name: FileAppender
       fileName: logs/application.log
-      filePattern: logs/archive/application-%d{yyyy-MM-dd}-%i.log
+      filePattern: logs/archive/application-%d{yyyy-MM-dd}-%i.log.gz
       PatternLayout:
         Pattern: "%d{DEFAULT} | %-5level | %thread | %msg %n %throwable"
       ThresholdFilter:
@@ -18,6 +18,16 @@ Configuration:
       Policies:
         OnStartupTriggeringPolicy:
           minSize: 0
+      DefaultRolloverStrategy:
+        max: 30
+        Delete:
+          basePath: logs/archive
+          maxDepth: 1
+          IfLastModified:
+            age: 30d
+          IfAccumulatedFileSize:
+            exceeds: 1GB
+
   Loggers:
     Root:
       level: debug

src/main/resources/log4j2-installed.yaml

@@ -1,17 +1,10 @@
 Configuration:
   name: DefaultLogger
   Appenders:
-    File:
-      name: FileAppender
-      fileName: ${sys:user.home}/AppData/Roaming/MyApplication/MyApplication.log
-      PatternLayout:
-        Pattern: "%d{DEFAULT} | %-5level | %thread | %msg %n %throwable"
-      ThresholdFilter:
-        level: info
     RollingFile:
       name: FileAppender
       fileName: ${sys:user.home}/AppData/Roaming/MKVAudioSubtitleChanger/logs/application.log
-      filePattern: ${sys:user.home}/AppData/Roaming/MKVAudioSubtitleChanger/logs/archive/application-%d{yyyy-MM-dd}-%i.log
+      filePattern: ${sys:user.home}/AppData/Roaming/MKVAudioSubtitleChanger/logs/archive/application-%d{yyyy-MM-dd}-%i.log.gz
       PatternLayout:
         Pattern: "%d{DEFAULT} | %-5level | %thread | %msg %n %throwable"
       ThresholdFilter:
@@ -19,6 +12,16 @@ Configuration:
       Policies:
         OnStartupTriggeringPolicy:
           minSize: 0
+      DefaultRolloverStrategy:
+        max: 30
+        Delete:
+          basePath: logs/archive
+          maxDepth: 1
+          IfLastModified:
+            age: 30d
+          IfAccumulatedFileSize:
+            exceeds: 1GB
+
   Loggers:
     Root:
       level: info

src/main/resources/log4j2.yaml

@@ -4,7 +4,7 @@ Configuration:
     RollingFile:
       name: FileAppender
       fileName: logs/application.log
-      filePattern: logs/archive/application-%d{yyyy-MM-dd}-%i.log
+      filePattern: logs/archive/application-%d{yyyy-MM-dd}-%i.log.gz
       PatternLayout:
         Pattern: "%d{DEFAULT} | %-5level | %thread | %msg %n %throwable"
       ThresholdFilter:
@@ -12,6 +12,16 @@ Configuration:
       Policies:
         OnStartupTriggeringPolicy:
           minSize: 0
+      DefaultRolloverStrategy:
+        max: 30
+        Delete:
+          basePath: logs/archive
+          maxDepth: 1
+          IfLastModified:
+            age: 30d
+          IfAccumulatedFileSize:
+            exceeds: 1GB
+
   Loggers:
     Root:
       level: info

src/test/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/config/ConfigTest.java

@@ -18,9 +18,9 @@ class ConfigTest {
                 "-c", "2",
                 "-t", "4",
                 "-i", ".*[abc].*",
-                "-fk", "testForced",
-                "-ck", "testCommentary",
-                "-ps", "testPreferred"
+                "--forced-keywords", "testForced",
+                "--commentary-keywords", "testCommentary",
+                "--preferred-subtitles", "testPreferred"
         };
         CommandLine.populateCommand(Config.getInstance(), sut);
 

src/test/java/at/pcgamingfreaks/mkvaudiosubtitlechanger/config/SetConfigParameterTest.java

@@ -19,14 +19,14 @@ class SetConfigParameterTest {
 
     private static Stream<Arguments> provideTestCases() {
         return Stream.of(
-                Arguments.of(args("-ck", "test"), 1, (Function<Config, Set<String>>) Config::getCommentaryKeywords),
-                Arguments.of(args("-ck", "test", "test1", "test2", "test3", "test4"), 5, (Function<Config, Set<String>>) Config::getCommentaryKeywords),
+                Arguments.of(args("--commentary-keywords", "test"), 1, (Function<Config, Set<String>>) Config::getCommentaryKeywords),
+                Arguments.of(args("--commentary-keywords", "test", "test1", "test2", "test3", "test4"), 5, (Function<Config, Set<String>>) Config::getCommentaryKeywords),
                 Arguments.of(args(), 2, (Function<Config, Set<String>>) Config::getCommentaryKeywords),
-                Arguments.of(args("-fk", "test"), 1, (Function<Config, Set<String>>) Config::getForcedKeywords),
-                Arguments.of(args("-fk", "test", "test1", "test2", "test3", "test4"), 5, (Function<Config, Set<String>>) Config::getForcedKeywords),
+                Arguments.of(args("--forced-keywords", "test"), 1, (Function<Config, Set<String>>) Config::getForcedKeywords),
+                Arguments.of(args("--forced-keywords", "test", "test1", "test2", "test3", "test4"), 5, (Function<Config, Set<String>>) Config::getForcedKeywords),
                 Arguments.of(args(), 3, (Function<Config, Set<String>>) Config::getForcedKeywords),
-                Arguments.of(args("-ps", "test"), 1, (Function<Config, Set<String>>) Config::getPreferredSubtitles),
-                Arguments.of(args("-ps", "test", "test1", "test2", "test3", "test4"), 5, (Function<Config, Set<String>>) Config::getPreferredSubtitles),
+                Arguments.of(args("--preferred-subtitles", "test"), 1, (Function<Config, Set<String>>) Config::getPreferredSubtitles),
+                Arguments.of(args("--preferred-subtitles", "test", "test1", "test2", "test3", "test4"), 5, (Function<Config, Set<String>>) Config::getPreferredSubtitles),
                 Arguments.of(args(), 1, (Function<Config, Set<String>>) Config::getPreferredSubtitles)
         );
     }
@@ -42,9 +42,9 @@ class SetConfigParameterTest {
     @Test
     void validate() {
         Main sut = new Main();
-        assertThrows(CommandLine.MissingParameterException.class, () -> CommandLine.populateCommand(sut, args("-ck")));
-        assertThrows(CommandLine.MissingParameterException.class, () -> CommandLine.populateCommand(sut, args("-fk")));
+        assertThrows(CommandLine.MissingParameterException.class, () -> CommandLine.populateCommand(sut, args("--commentary-keywords")));
+        assertThrows(CommandLine.MissingParameterException.class, () -> CommandLine.populateCommand(sut, args("--forced-keywords")));
         assertThrows(CommandLine.MissingParameterException.class, () -> CommandLine.populateCommand(sut, args("-e")));
-        assertThrows(CommandLine.MissingParameterException.class, () -> CommandLine.populateCommand(sut, args("-ps")));
+        assertThrows(CommandLine.MissingParameterException.class, () -> CommandLine.populateCommand(sut, args("--preferred-subtitles")));
     }
 }